Project

General

Profile

Actions

Development #1358

closed

Development #1353: Code cleanup for OCT19

Code cleanup: PLUTO

Added by Volker Friese almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
09/10/2019
Due date:
10/07/2019
% Done:

100%

Estimated time:
2.00 h
Spent time:

Description

The following warnings appear when compiling the PLUTO classes included into CbmRoot (generators/pluto):

Cbmroot/OCT19/source/generators/pluto/PDataBase.cxx:576:19: warning: declaration shadows a field of 'PDataBase' [-Wshadow]
        Int_t listkey=-1,lastkey;
                         ^
Cbmroot/OCT19/source/generators/pluto/PDataBase.h:57:11: note: previous declaration is here
    Int_t lastkey;

Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:241:15: warning: declaration shadows a local variable [-Wshadow]
            for (int ii=0;ii<np;++ii) {   // loop over product particles
                     ^
Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:131:18: note: previous declaration is here
    int pkey=-1,*ii;
                 ^

What is the status of this software? Can it be fixed?
Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:248:10: warning: declaration shadows a local variable [-Wshadow]
                Int_t *pkey = new int(base->GetEntryInt("pid",pid));
                       ^
Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:131:9: note: previous declaration is here
    int pkey=-1,*ii;
Actions #1

Updated by Florian Uhlig almost 3 years ago

  • Status changed from Assigned to In Progress
  • % Done changed from 0 to 90
Actions #2

Updated by Florian Uhlig almost 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100
Actions #3

Updated by Florian Uhlig almost 3 years ago

  • Assignee changed from Florian Uhlig to Volker Friese
Actions #4

Updated by Volker Friese almost 3 years ago

  • Status changed from Resolved to Closed

Warnings disappeared from tests of trunk and OCT19. Thanks.

Actions

Also available in: Atom PDF