Development #1358: Code cleanup: PLUTO - CbmRoot - CBM

Actions

Copy link

Development #1358

closed

Development #1353: Code cleanup for OCT19

Code cleanup: PLUTO

Added by Volker Friese almost 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Volker Friese

Target version:

OCT19

Start date:

09/10/2019

Due date:

10/07/2019

% Done:

100%

Estimated time:

2.00 h

Spent time:

0.75 h

Description

The following warnings appear when compiling the PLUTO classes included into CbmRoot (generators/pluto):

Cbmroot/OCT19/source/generators/pluto/PDataBase.cxx:576:19: warning: declaration shadows a field of 'PDataBase' [-Wshadow]
        Int_t listkey=-1,lastkey;
                         ^
Cbmroot/OCT19/source/generators/pluto/PDataBase.h:57:11: note: previous declaration is here
    Int_t lastkey;

Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:241:15: warning: declaration shadows a local variable [-Wshadow]
            for (int ii=0;ii<np;++ii) {   // loop over product particles
                     ^
Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:131:18: note: previous declaration is here
    int pkey=-1,*ii;
                 ^

What is the status of this software? Can it be fixed?
Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:248:10: warning: declaration shadows a local variable [-Wshadow]
                Int_t *pkey = new int(base->GetEntryInt("pid",pid));
                       ^
Cbmroot/OCT19/source/generators/pluto/PStdData.cxx:131:9: note: previous declaration is here
    int pkey=-1,*ii;