Development #1360: Code cleanup: fles/star2017/unpacker/star_rhicf.c - CbmRoot - CBM

Actions

Copy link

Development #1360

closed

Development #1353: Code cleanup for OCT19

Code cleanup: fles/star2017/unpacker/star_rhicf.c

Added by Volker Friese almost 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Volker Friese

Target version:

OCT19

Start date:

09/10/2019

Due date:

10/07/2019

% Done:

100%

Estimated time:

1.00 h

Spent time:

0.33 h

Description

Cbmroot/OCT19/source/fles/star2017/unpacker/star_rhicf.c:120:62: warning: passing 'int *' to parameter of type 'socklen_t *' (aka 'unsigned int *') converts
      between pointers to integer types with different sign [-Wpointer-sign]
                ret = getsockopt(desc,SOL_SOCKET,SO_SNDBUF,(char *)&optval,&size) ;
                                                                           ^~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/sys/socket.h:694:76: note: passing argument to parameter here
int     getsockopt(int, int, int, void * __restrict, socklen_t * __restrict);

Please fix if possible.

Actions

Copy link

Updated by Pierre-Alain Loizeau almost 3 years ago

Status changed from Assigned to Resolved
Assignee changed from Pierre-Alain Loizeau to Volker Friese
% Done changed from 0 to 100

Should be resolved by hiding the warning for only this file as I do not find the error anymore in cdash or locally, please close the issue if it is also gone for you.

Actions

Copy link

Updated by Volker Friese almost 3 years ago

The warning disappeared from the local build (clang) and the tests on trunk. Still in OCT19 tests (not backported in time). Wait for tomorrow to check and close the issue.

Actions

Copy link