Actions
Development #1369
closedDevelopment #1353: Code cleanup for OCT19
Code cleanup: much/reco/CbmMuchDigitizeGem.h
Description
Compiler warnings:
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:50:15: warning: 'sigma_e' defined but not used [-Wunused-variable]
static double sigma_e[] = { 4.06815, -0.225699, 0.464502, -0.141208, 0.0226821,-0.00195697, 6.87497e-05 };
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:51:15: warning: 'sigma_mu' defined but not used [-Wunused-variable]
static double sigma_mu[] = { 74.5272, -49.7648, 14.4886, -2.23059, 0.188254,-0.00792744, 0.00011976 };
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:52:15: warning: 'sigma_p' defined but not used [-Wunused-variable]
static double sigma_p[] = { 175.879, -15.016, -34.6513, 13.346, -2.08732, 0.153678,-0.00440115 };
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:53:15: warning: 'mpv_e' defined but not used [-Wunused-variable]
static double mpv_e[] = { 14.654, -0.786582, 2.32435, -0.875594, 0.167237,-0.0162335, 0.000616855 };
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:54:15: warning: 'mpv_mu' defined but not used [-Wunused-variable]
static double mpv_mu[] = { 660.746, -609.335, 249.011, -55.6658, 7.04607, -0.472135, 0.0129834 };
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:55:15: warning: 'mpv_p' defined but not used [-Wunused-variable]
static double mpv_p[] = { 4152.73, -3123.98, 1010.85, -178.092, 17.8764, -0.963169, 0.0216643 };
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:56:15: warning: 'min_logT_e' defined but not used [-Wunused-variable]
static double min_logT_e = -3.21888;
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:57:15: warning: 'min_logT_mu' defined but not used [-Wunused-variable]
static double min_logT_mu = -0.916291;
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:58:15: warning: 'min_logT_p' defined but not used [-Wunused-variable]
static double min_logT_p = 1.0986;
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:59:15: warning: 'l_e' defined but not used [-Wunused-variable]
static double l_e = 0.47;
^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/much/reco/CbmMuchDigitizeGem.h:60:15: warning: 'l_not_e' defined but not used [-Wunused-variable]
static double l_not_e = 0.36;
^
These static variables are never used in the code. They are probably a legacy (implemented by E. Kryshen back in 2011). Please check and remove them if really not needed.
Updated by Volker Friese almost 3 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
Fixed.
Updated by Volker Friese almost 3 years ago
- Status changed from Closed to In Progress
- Assignee changed from Vikas Singhal to Florian Uhlig
- % Done changed from 100 to 50
No, not fixed; new error from gcc7 (CbmMuchHitFinderQa.cxx including the new CbmMuchRecoDefs.h):
In file included from /scratch/uhlig/cbmroot/oct19/much/reco/CbmMuchHitFinderQa.cxx:31:0:
[CTest: warning matched] /scratch/uhlig/cbmroot/oct19/much/reco/CbmMuchRecoDefs.h:22:15: warning: ‘l_not_e’ defined but not used [-Wunused-variable]
static double l_not_e = 0.36;
^~~~~~~
[CTest: warning matched] /scratch/uhlig/cbmroot/oct19/much/reco/CbmMuchRecoDefs.h:21:15: warning: ‘l_e’ defined but not used [-Wunused-variable]
static double l_e = 0.47;
^~~
[CTest: warning matched] /scratch/uhlig/cbmroot/oct19/much/reco/CbmMuchRecoDefs.h:14:15: warning: ‘sigma_p’ defined but not used [-Wunused-variable]
static double sigma_p[] = { 175.879, -15.016, -34.6513, 13.346, -2.08732, 0.153678,-0.00440115 };
^~~~~~~
[CTest: warning matched] /scratch/uhlig/cbmroot/oct19/much/reco/CbmMuchRecoDefs.h:13:15: warning: ‘sigma_mu’ defined but not used [-Wunused-variable]
static double sigma_mu[] = { 74.5272, -49.7648, 14.4886, -2.23059, 0.188254,-0.00792744, 0.00011976 };
^~~~~~~~
[CTest: warning matched] /scratch/uhlig/cbmroot/oct19/much/reco/CbmMuchRecoDefs.h:12:15: warning: ‘sigma_e’ defined but not used [-Wunused-variable]
static double sigma_e[] = { 4.06815, -0.225699, 0.464502, -0.141208, 0.0226821,-0.00195697, 6.87497e-05 };
^~~~~~~
Your solution to introduce a new header file just shifts the problem.
Updated by Volker Friese almost 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 50 to 100
Fixed.
Actions