Project

General

Profile

Actions

Development #1377

closed

Development #1353: Code cleanup for OCT19

Code cleanup: analysis/cbmfemto/helpers/CbmHelix.cxx

Added by Volker Friese almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
09/16/2019
Due date:
09/27/2019
% Done:

100%

Estimated time:
1.00 h
Spent time:

Description

Compiler warnings:

/home/uhlig/cbm/release/oct19/analysis/cbmfemto/helpers/CbmHelix.cxx: In copy constructor 'CbmHelix::CbmHelix(const CbmHelix&)':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/analysis/cbmfemto/helpers/CbmHelix.cxx:61:1: warning: base class 'class TObject' should be explicitly initialized in the copy constructor [-Wextra]
 CbmHelix::CbmHelix(const CbmHelix &other) {
 ^
/home/uhlig/cbm/release/oct19/analysis/cbmfemto/helpers/CbmHelix.cxx: In member function 'Int_t CbmHelix::Propagate(Double_t)':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/analysis/cbmfemto/helpers/CbmHelix.cxx:77:37: warning: declaration of 'Z' shadows a member of 'this' [-Wshadow]
 Int_t CbmHelix::Propagate(Double_t Z) {
                                     ^
/home/uhlig/cbm/release/oct19/analysis/cbmfemto/helpers/CbmHelix.cxx: In member function 'Int_t CbmHelix::ExtrapolateALight(Double_t)':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/analysis/cbmfemto/helpers/CbmHelix.cxx:351:11: warning: variable 'T_out' set but not used [-Wunused-but-set-variable]
  Double_t T_out[6] = { 0, 0, 0, 0, 0, 0 };
           ^

Please fix.

Actions #1

Updated by Volker Friese almost 3 years ago

Dear Daniel,

if you have completed the issue, please mark its status "Resolved" and the % done as 100%. In the future, please connect the commit to the issue by adding "Refs #[issue number]" to the commit message.

Actions #2

Updated by Volker Friese almost 3 years ago

  • Status changed from Assigned to In Progress

The last warning (line 351) still remains.

Actions #3

Updated by Daniel Wielanek almost 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Fixed in trunk version.

Actions #4

Updated by Volker Friese almost 3 years ago

  • Status changed from Resolved to Closed

All fine now.

Actions

Also available in: Atom PDF