Development #1380: Code cleanup: rich/prototype - CbmRoot - CBM

Actions

Copy link

Development #1380

closed

Development #1353: Code cleanup for OCT19

Code cleanup: rich/prototype

Added by Volker Friese almost 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Semen Lebedev

Target version:

OCT19

Start date:

09/16/2019

Due date:

09/27/2019

% Done:

100%

Estimated time:

2.00 h

Spent time:

0.50 h

Description

Compiler warnings:

/home/uhlig/cbm/release/oct19/rich/prototype/CbmRichProtHitProducer.cxx: In member function 'void CbmRichProtHitProducer::FindRichHitPositionSinglePMT(Double_t, Double_t, Double_t&, Double_t&, Int_t&)':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/CbmRichProtHitProducer.cxx:1457:74: warning: 'vPoint' may be used uninitialized in this function [-Wmaybe-uninitialized]
    distance = TMath::Sqrt((uPMT-uPoint)*(uPMT-uPoint)+(vPMT-vPoint)*(vPMT-vPoint)*TMath::Cos(alpha)*TMath::Cos(alpha));
                                                                          ^
/home/uhlig/cbm/release/oct19/rich/prototype/CbmRichProtHitProducer.cxx: In member function 'void CbmRichProtHitProducer::FindRichHitPositionCsI(Double_t, Double_t, Double_t&, Double_t&, Int_t&)':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/CbmRichProtHitProducer.cxx:1590:86: warning: 'vPoint' may be used uninitialized in this function [-Wmaybe-uninitialized]
       if (vPoint < vPMT) cout << " -E- HitProducer: calculation of CsI unit (v) " << vPoint << " " << vPMT << endl;
                                                                                      ^

/home/uhlig/cbm/release/oct19/rich/prototype/CbmRichProtProjectionProducer.cxx: In member function 'virtual void CbmRichProtProjectionProducer::Init()':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/CbmRichProtProjectionProducer.cxx:142:13: warning: variable 'thetaM' set but not used [-Wunused-but-set-variable]
    Double_t thetaM[4];
             ^

/home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmTrbEdgeMatcher.cxx: In member function 'void CbmTrbEdgeMatcher::DrawDebugHistos()':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmTrbEdgeMatcher.cxx:553:13: warning: variable 'c2' set but not used [-Wunused-but-set-variable]
    TCanvas* c2[16];
             ^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmTrbEdgeMatcher.cxx:554:13: warning: variable 'c3' set but not used [-Wunused-but-set-variable]
    TCanvas* c3;
             ^

/home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmTrbCalibrator.cxx: In member function 'Double_t CbmTrbCalibrator::GetFineTimeCalibrated(UShort_t, UShort_t, UShort_t)':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmTrbCalibrator.cxx:285:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

/home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmRichTrbEventBuilder.cxx: In member function 'void CbmRichTrbEventBuilder::InitHist()':
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmRichTrbEventBuilder.cxx:70:12: warning: variable 'K' set but not used [-Wunused-but-set-variable]
   Double_t K, minWin, maxWin;
            ^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmRichTrbEventBuilder.cxx:70:15: warning: variable 'minWin' set but not used [-Wunused-but-set-variable]
   Double_t K, minWin, maxWin;
               ^
[CTest: warning matched] /home/uhlig/cbm/release/oct19/rich/prototype/beamtime/CbmRichTrbEventBuilder.cxx:70:23: warning: variable 'maxWin' set but not used [-Wunused-but-set-variable]
   Double_t K, minWin, maxWin;
                       ^