Project

General

Profile

Actions

Development #1389

closed

Development #1353: Code cleanup for OCT19

Code cleanup: external

Added by Volker Friese almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
09/21/2019
Due date:
09/27/2019
% Done:

100%

Estimated time:
1.00 h
Spent time:

Description

The following warning shows up in my local build (clang) and in the CDash tests on demac, but not on lxbuild:

[CTest: warning suppressed] /Users/uhlig/software/fair/cbm/cbmroot_oct19/external/flib_dpb_20/flib_dpb_20/MicrosliceContents20.cpp:68:10: warning: unused variable 'size' [-Wunused-variable]
    auto size    = size_t(data);
         ^
[CTest: warning suppressed] /Users/uhlig/software/fair/cbm/cbmroot_oct19/external/flib_dpb_20/flib_dpb_20/MicrosliceContents20.cpp:66:10: warning: unused variable 'empty' [-Wunused-variable]
    auto empty   = uint16_t {*data_r++};
         ^
[CTest: warning matched] 2 warnings generated.

In addition, in my local build I get

[ 75%] Built target DATATREE
[ 75%] Generating G__DataTreeCbmInterfaceDict.cxx, G__DataTreeCbmInterfaceDict_rdict.pcm, ../../../lib/libDataTreeCbmInterface.rootmap
In file included from input_line_12:47:
In file included from /Users/vfriese/Cbmroot/trunk/build/include/DataTreeEvent.h:12:
In file included from /Users/vfriese/Cbmroot/trunk/build/include/DataTreeTrack.h:15:
/Users/vfriese/Cbmroot/trunk/build/include/DataTreeConstants.h:106:9: warning: Compiling CBM Configuration [-W#pragma-messages]
#pragma message ("Compiling CBM Configuration")
        ^
In file included from <<< cling interactive line includer >>>:1:
In file included from /Users/vfriese/Cbmroot/trunk/source/analysis/flow/DataTreeCbmInterface/DataTreeCbmInterface.h:27:
In file included from /Users/vfriese/Cbmroot/trunk/build/include/DataTreeEvent.h:12:
In file included from /Users/vfriese/Cbmroot/trunk/build/include/DataTreeTrack.h:15:
/Users/vfriese/Cbmroot/trunk/build/include/DataTreeConstants.h:106:9: warning: Compiling CBM Configuration [-W#pragma-messages]
#pragma message ("Compiling CBM Configuration")
        ^

This latter warning is not seen in CDash.

I thought errors from the external software were excluded - why do these two show up?

Actions #1

Updated by Florian Uhlig almost 3 years ago

  • Assignee changed from Florian Uhlig to Volker Friese
  • % Done changed from 0 to 100

Why the first warning shows up I don't understand. The warning is filtered as you can see in the warning

[CTest: warning suppressed]

but nevertheless shows up on CDash. The filter works without problems for other external directories and even works for this directory on other systems.

The second warning is also filtered but shows up locally since the the setting "-W#pragma-messages" is enabled on macOSX.

Actions #2

Updated by Volker Friese almost 3 years ago

  • Status changed from Assigned to Closed

Fixed, also in local build.

Actions

Also available in: Atom PDF