Project

General

Profile

Actions

Sim-Development #1542

closed

Sim-Development #1536: Remove all inheritance from digi classes

Remove inheritance of digi classes from CbmDigi

Added by Volker Friese over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
02/28/2020
Due date:
03/02/2020
% Done:

100%

Estimated time:
1.00 h
Spent time:

Description

After accomplishing this, the base class CbmDigi is not needed any longer and can be removed.


Related issues

Follows Simulation - Sim-Development #1541: Adapt digi consumer classes to handle digis without baseclass CbmDigiClosedVolker Friese02/21/202002/27/2020

Actions
Actions #1

Updated by Volker Friese over 2 years ago

  • Due date changed from 02/28/2020 to 03/02/2020
  • Start date changed from 02/27/2020 to 02/28/2020
  • Follows Sim-Development #1541: Adapt digi consumer classes to handle digis without baseclass CbmDigi added
Actions #2

Updated by Volker Friese over 2 years ago

  • % Done changed from 0 to 90

All digi classes do not derive from CbmDigi any longer.

Actions #3

Updated by Volker Friese over 2 years ago

Next step would be to remove the CbmDigi class as such. Will be interesting to see where it is still used...

Actions #4

Updated by Volker Friese over 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 90 to 100

OK, CbmDigi is history now. CbmDaqBuffer went along.

All classes could be adapted, with one exception: fles/mcbm2018/tasks/CbmMcbm2018EventBuilder. This has to be re-designed. It is taken out of the build by now, it does not work anyhow (though was still compiling before) without the digi objects inherting from CbmDigi.

Actions #5

Updated by Volker Friese over 2 years ago

  • Status changed from Resolved to Closed

I have adapted also CbmMcbm2018EventBuilder. The digi base class was used only for retrieving the digi time when sorting. I circumvented that by implementing the sorter as multimap with key time, instead of the prviously used set. Histogram filling is commented out, though.

Since both map and set are associative containers, the performance should not be much worse, in particular since these containers hold only a small number of objects at a time (one for each detector).

I thus close this issue.

Actions

Also available in: Atom PDF