Project

General

Profile

Actions

Sim-Development #1543

closed

TOF digitizer

Added by Volker Friese over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Urgent
Target version:
Start date:
02/15/2020
Due date:
02/17/2020
% Done:

100%

Estimated time:
Spent time:

Description

In the context of adapting the TOF digitizer, I have the following questions:

1. In the repository, there are CbmTofDigitizer and CbmTofDigitizerBDF. By default, CbmTofDigitizer is used in our simulations. Is the class CbmTofDigitizerBDF still needed or can it be removed?

2. CbmTofDigitizer creates alternatively CbmTofDigi or CbmTofDigiExp. This will not be possible in the new scheme, because the output digi class is defined by the specialisation of the CbmDigitzeBase template. By default, CbmTofDigiExp is used. Is the distinction still needed or obsolete? If both are needed, they will lead to two digitizer classes.

3. In the TOF digitizer, a lot of monitoring / histogramming is included. This makes the code very hard to read and maintain. Is it indispensable that this monitoring is performed during the actual simulation, or could it be done in a separate QA task to be run on the output of the simulation?

I am willing to perform the necessary changes. Please let me know the answers to the above questions such that I can proceed.

Actions #1

Updated by Volker Friese over 2 years ago

  • Parent task deleted (#1538)

Is not actually a showstopper for #1538, but should be resolved anyway.

Actions #2

Updated by Pierre-Alain Loizeau over 2 years ago

  • Status changed from Assigned to In Progress
  • % Done changed from 0 to 10
  1. We should simply check if CbmTofDigitizerBDF is still used anywhere. To my knowledge it should be deprecated. => "Recent user feedback" should come from Norbert
  2. This was fixed with r.15798
  3. Was important at the beginning to evaluate the effect of the different options and of the parameters provided from real detectors analysis. As neither the options nor the "real" parameters were properly tuned in the end, I am not sure if this is still needed => "Recent user feedback" should come from Norbert

==> I cannot change the assigned person on this issue, but I think it should be set to Norbert or Christian Simon

Actions #3

Updated by Volker Friese over 2 years ago

  • Assignee changed from Pierre-Alain Loizeau to Christian Simon

Dear Christian,

could you comment, please?

Actions #4

Updated by Christian Simon over 2 years ago

Dear Volker,

To my knowledge, Norbert and Qiunan Zhang are - in contrast to me - currently making active use of the ToF digitization classes. So it would be best to request feedback from them.

Actions #5

Updated by Norbert Herrmann about 2 years ago

  • % Done changed from 10 to 30

As far as I can see the functionality of CbmTofDigitizerBDF is now integrated in CbmTofDigitizer.
Since CbmTofDigitizerBDF is not used in any macro of the repository, it can be removed.

Best regards, Norbert

Actions #6

Updated by Volker Friese about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 30 to 100

OK, I have removed CbmTofDigitizerBDF.

Actions

Also available in: Atom PDF