Project

General

Profile

Actions

Development #301

closed

Development #295: STS NOV15

Modifications needed to adapt the COSY beamtime reco classes after deprecations in STS data classes

Added by Pierre-Alain Loizeau about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
06/19/2015
Due date:
% Done:

100%

Estimated time:
Spent time:

Description

In rev. 7648, some fields in the CbmStsCluster and CbmStsHit data classes were deprecated:
1) CbmStsCluster->Mean was replaced by CbmStsCluster->Center
2) CbmStsCluster->MeanError was partially replaced by CbmStsCluster->channelMeanSq
3) CbmStsHit->SectorNb was fully deprecated

I made some adaptation to use the new fields and allow compilation and a behavior as close as possible to original.
However I had to use fix errors in StsCosyClusterFinder and to use unused data field for the detector ID in CbmStsHit, so this need to be checked and done in a better way.

Affected files are:
beamtime/reco/StsCosyHitFinder.cxx
beamtime/reco/StsCosyTrack.cxx
beamtime/reco/StsCosyClusterFinder.cxx

Actions #1

Updated by Pierre-Alain Loizeau about 7 years ago

Associated commit: revision 7772

Actions #2

Updated by Volker Friese about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Pierre-Alain Loizeau
  • Target version set to NOV15
  • Parent task set to #295

Please state if you need some modifications in the STS cluster and/or hit classes.

Actions #3

Updated by Pierre-Alain Loizeau about 7 years ago

  • % Done changed from 0 to 50

The changes were commited to trunk by Florian in rev. 7819.

An accessor to "fChannelMeanSq" in CbmStsCluster would allow to get back the original error calculation method.

The other "hack" is that I used the frontDigiId field in CbmStsHit to store the station index instead of the deprecated SectorNb. Here I am not sure that a modificationto the data class would improve anything.

Actions #4

Updated by Pierre-Alain Loizeau almost 7 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100

Modifications done in rev. 8294. Issue resolved, can be closed after somebody checks with a COSY file that results are now identical to old behavior.

Actions #5

Updated by Pierre-Alain Loizeau almost 7 years ago

  • Status changed from Resolved to Closed

Anna did her own modifications in her not yet committed version of the COSY unpacker. Eventually the changes done for this issue will need to be also done in her version, an email with a link to this issue was sent to her.

Actions

Also available in: Atom PDF