Project

General

Profile

Actions
Copy link

Bug #491

closed

Development #483: Code cleanup

Shadowing of CbmMvdSensorPlugin::Init()

Added by Volker Friese over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Philipp Sitzmann
Target version:
NOV15
Start date:
11/24/2015
Due date:
11/25/2015
% Done:

100%

Estimated time:

Description

This function shadows the virtual method void CbmMvdSensorPlugin::Init(), which has no arguments. The same situation holds for CbmMvdSensorBuffer. Please reconsider the design of CbmMvdSensorPlugin and these two derived classes.

Actions
Copy link
 #1

Updated by Volker Friese over 6 years ago

  • Due date set to 11/26/2015
  • Priority changed from Normal to High
Actions
Copy link
 #2

Updated by Philipp Sitzmann over 6 years ago

  • % Done changed from 0 to 100

Fixed the shadowing

Actions
Copy link
 #3

Updated by Volker Friese over 6 years ago

  • Due date changed from 11/26/2015 to 11/25/2015
  • Status changed from Assigned to Closed

Thanks for the fix (done in r8824). Ported back to NOV15 in r8843.

For the future, it would be nice if you could link the commit to the issue by including "Refs #xxx" in the commit message, where xxx is the issue number.

Actions
Copy link

Also available in: Atom PDF