Project

General

Profile

Actions

Bug #717

closed

CbmLitFindGlobalTracks throws error when not finding hit arrays

Added by Volker Friese about 6 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
06/17/2016
Due date:
08/06/2019
% Done:

100%

Estimated time:
Spent time:

Description

The class CbmLitFindGlobalTracks throws a FATAL if a detector is found in the geometry setup, but no corresponding hit branch in the input.

This behaviour is not correct. It is perfectly legal and foreseen in FairDetector to build a detector in the geometry, but set it inactive, such that it does not produce MCPoints. In such a case, there will be no hits, of course.

Actions #1

Updated by Volker Friese almost 6 years ago

Dear Andrey,

can you please comment?

Actions #2

Updated by Andrey Lebedev almost 6 years ago

Dear Volker,
I think this is a correct behaviour.
If the detector is inactive and does not produce MCPoints or hits than the number of entries in the corresponding TCloneArrays should be 0.
But the branch has to be registered in any case.
In my opinion this is much less error prone.

Actions #3

Updated by Volker Friese almost 3 years ago

  • Due date set to 08/06/2019
  • Status changed from Assigned to Closed
  • Assignee changed from Andrey Lebedev to Volker Friese
  • Target version set to OCT19
  • % Done changed from 0 to 100

There is also the possibility that the output branch is deactivated for persistency (when registering it). So, I think there should not be a fatal when the branch is not found in the input tree (unless it is necessary, as e.g. StsTrack for littrack).

I have changed CbmLitFindGlobalTracks accordingly. When an input branch is not present, the corresponding detector is decativated in CbmLitDetectorSetup and thus not regarded in further reconstruction.

Actions

Also available in: Atom PDF